Cfml language support#1118
Closed
ghedwards wants to merge 2 commits into
Closed
Conversation
Adds CodeGraph extraction for ColdFusion Markup Language using
tree-sitter-cfml's cfml and cfscript grammars. Handles both the legacy
tag-based style (<cfcomponent>/<cffunction>) and modern bare-script
style (component { ... }), delegating embedded <cfscript> tag bodies
to the cfscript grammar. .cfs files are routed through the same
extractor so anonymous component names fall back to the filename
consistently across both extensions, since CFML never declares a
component's name in source.
Includes extraction tests covering both dialects, extends/implements,
visibility, and regression coverage for the implicit-end-tag walk and
file-node containment.
… cfquery SQL bodies A <cfscript> block nested inside control-flow tags (<cfif>/<cfloop>/<cftry>) inside a <cffunction> or at top-level component scope was silently skipped: the implicit-end-tag walk only checked direct children/siblings for cf_script_tag, missing it when wrapped a level deeper. A new recursive delegateNestedTags helper finds <cfscript>/<cfquery> at any depth without descending into nested <cffunction> scopes. <cfquery> SQL bodies were also entirely unhandled - the cf_query_content node's text was opaque raw SQL, so any #hash# expression inside it (e.g. a call like #getCurrentUser().getId()# in a WHERE clause) was dropped. Wires the tree-sitter-cfml cfquery grammar in as a new minimal Language/extractor (call expressions only - the grammar models no other CodeGraph symbols) and delegates <cfquery> bodies to it the same way <cfscript> bodies are delegated to the cfscript grammar.
This was referenced Jul 2, 2026
colbymchenry
added a commit
that referenced
this pull request
Jul 2, 2026
…1153) Tag-based and bare-script CFML, extends/implements, <cfscript>/<cfquery> delegation, BOM + unquoted-attribute handling. Wasm grammars verified bit-for-bit reproducible from cfmleditor/tree-sitter-cfml. Validated on FW/1, ColdBox, CFWheels. Follow-up: #1152. Co-authored-by: ghedwards <125586+ghedwards@users.noreply.github.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
|
Thank you for this — reviewed and merged today via #1153 (your branch doesn't allow maintainer edits, so I couldn't push the review fixes to this PR directly; your commits carry over and the squash commit credits you as co-author). The review verified the wasm grammars are bit-for-bit reproducible from
One follow-up worth knowing about if you want to keep going — #1152: dotted-path CFML ships in the next release. Thanks again — closing this in favor of #1153. |
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.